FIX: Zip feature detection and exception logging #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unexpected exceptionswrapped as `ParseException` to allow uniform handling; - added to validation and parsing interfaces; - `ParseException`s are logged as errors, other files are still processed; - `PackageParser` now checks for unsuppported zip features; - other code cleanup to catch exceptions early and pass `ParseException`s up the stack; and - changed test cases to match new method sigs.
This was
linked to
issues
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseExceptionto allow uniform handling;ParseExceptions are logged as errors, other files are still processed;PackageParsernow checks for unsuppported zip features;ParseExceptions up the stack; and