Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Seurat's RPCA method to Benchmarking tasks? #452

Open
andrewdchen opened this issue May 23, 2024 · 3 comments
Open

Adding Seurat's RPCA method to Benchmarking tasks? #452

andrewdchen opened this issue May 23, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@andrewdchen
Copy link

Hello!

I noticed that Seurat's RPCA integration method was not included in either the 'Batch integration embed' task or the 'Batch integration feature' task. I know that RPCA is capable of both and it's a method that is often the first off-the-shelf R method that people choose, so I would be interested in seeing this added.
I would also be happy to work on this too!

@andrewdchen andrewdchen added the enhancement New feature or request label May 23, 2024
@LuckyMD
Copy link

LuckyMD commented May 23, 2024

Hi @andrewdchen,

Please feel free to add the method. We'd love to see it included here.
@danielStrobl: you had started adding it as well, no? Were there environment handling issues?

@KaiWaldrant
Copy link
Member

You can use the the documentation to guide you and you can always ask us for guidance. https://openproblems.bio/documentation/create_component/add_a_method

We also have a coworking session on the Openproblems Discord on Friday. https://openproblems.bio/events/weekly_coworking/

@danielStrobl
Copy link
Contributor

I think that was in v1 where I was having the environment issues with seurat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants