Generate recipe pages with version placeholders #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
added
documentation
|
There appears to be a rendering issue in openrewrite/rewrite-docs#327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from a change just before where we generate a latest-versions.js: 2651736
Which is already used in rewrite-docs to render these placeholders for guides: openrewrite/rewrite-docs@831f772
What's changed?
Change the generator to produce recipe pages with version placeholders, instead of explicit versions.
What's your motivation?
Reduce the diff whenever we release a new version, to make it a change manageable in a review, as opposed to 3K files changed.
Anything in particular you'd like reviewers to focus on?
Are there further simplifications we can do now?