-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links to example research code where that code is old and unmaintained #1573
Comments
I've spoken to Brian and someone in the research team will be able to update this code. |
no action needed
non-urgent action needed
|
Don't know if this fits here, but some references to modifying study def variables in cohortextractor here: I'm not even sure what that paragraph is about so unsure if it needs updating, or deleting (I suspect the latter though). |
As spotted by @alschaffer in this issue: #1573 (comment) The relevant file has been edited just four times in the last two years, and not since mid-2023. Realistically, the only people who might make small updates to cohort-extractor are likely to be developers now, and this note probably just mystifies anyone else who encounters it.
It's not really helpful now as it doesn't apply to ehrQL, so I deleted it in #1642. |
@StevenMaude While updating docs (#1639) on the new project.yaml version (which deprecated cohort-extractor), @alarthast noticed that there is also the case control studies example in |
In #1572, it was noted that there is at least one link to research code that doesn't do things exactly as might be the OpenSAFELY best practice today (it uses
run: jupyter:latest
and notrun: python:v2
).Links to code repositories are currently in:
docs/data-sources/apc.md
docs/data-sources/ecds.md
docs/data-sources/systmone.md
docs/data-sources/cpns.md
docs/federation.md
docs/protocol.md
docs/reports/intro.md
docs/study-def-flowcharts.md
docs/study-def-tricks.md
If these are outdated, we should replace them with more current examples.
The text was updated successfully, but these errors were encountered: