-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.14] fix: correct clusterrole permissions (#4016) #1136
[release-v1.14] fix: correct clusterrole permissions (#4016) #1136
Conversation
Signed-off-by: Calum Murray <[email protected]>
/test 415-test-reconciler-keda-aws-415 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test 415-test-reconciler-keda-aws-415 |
/test 415-test-conformance-aws-415 |
/hold Revision 80643cd was retested 3 times: holding |
/retest |
@Cali0707: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Duplicate of #1157 |
This is a backport of knative-extensions#4016 to make sure that the post install job has the correct permissions