Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] fix: correct clusterrole permissions (#4016) #1158

Conversation

Cali0707
Copy link
Member

This is a cherry pick of knative-extensions#4016 to make sure that post install jobs have the correct permissions in the clusterrole

@openshift-ci openshift-ci bot requested review from matzew and pierDipi August 19, 2024 12:36
@pierDipi
Copy link
Member

/retest
/lgtm
/approve

Copy link

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved and removed lgtm labels Sep 10, 2024
Copy link

openshift-ci bot commented Sep 10, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Sep 12, 2024

@Cali0707: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/415-test-reconciler-keda-aws-415 4231275 link true /test 415-test-reconciler-keda-aws-415
ci/prow/415-test-reconciler-aws-415 4231275 link true /test 415-test-reconciler-aws-415
ci/prow/415-test-reconciler-encryption-auth-aws-415 4231275 link true /test 415-test-reconciler-encryption-auth-aws-415

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi pierDipi force-pushed the backport-post-install-clusterrole-v1.15 branch from 4231275 to 4346351 Compare September 16, 2024 15:34
@pierDipi pierDipi merged commit b9c5bfe into openshift-knative:release-v1.15 Sep 16, 2024
0 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants