Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][RELEASE-v1.9] Backport use of informer #94

Closed
wants to merge 3 commits into from
Closed

[WIP][RELEASE-v1.9] Backport use of informer #94

wants to merge 3 commits into from

Conversation

nak3
Copy link

@nak3 nak3 commented Aug 10, 2023

No description provided.

nak3 and others added 3 commits August 10, 2023 11:59
* User informer to  startupTranslator

* remove comment

* Do not use kubeClient for ingress
…at startup (knative-extensions#1079)

* Update getReadyIngresses to load ingresses at startup

Indeed, we can't use label selector as kourier class is not a label, but an annotation. As a result, kourier does not sync ingresses at startup

* Explain KUBE_API_BURST and KUBE_API_QPS
@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Author

nak3 commented Aug 10, 2023

@nak3 nak3 closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants