Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "add cluster profile for konflux workspaces" #4074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "add cluster profile for konflux workspaces" #4074

wants to merge 1 commit into from
+1 −6

Conversation

sadlerap
Copy link
Contributor

@sadlerap sadlerap commented Apr 9, 2024

This cluster profile is no longer needed. It has no current users, and it will not be used in the future.

This reverts commit 18b957a.

@openshift-ci openshift-ci bot requested review from jmguzik and psalajova April 9, 2024 18:17
@sadlerap
Copy link
Contributor Author

sadlerap commented Apr 9, 2024

For context: after discussions with the konflux QE team, I was informed that we will not need our own cluster profile use on https://github.com/konflux-workspaces/workspaces.

cc: @ascerra

@psalajova
Copy link
Contributor

/retest-required

@psalajova
Copy link
Contributor

/approve

@psalajova
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psalajova, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 12, 2024
@psalajova
Copy link
Contributor

/test e2e

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5f5fad8 and 2 for PR HEAD 7313d78 in total

@sadlerap
Revert "add cluster profile for konflux workspaces"
def5512 
This cluster profile is no longer needed.  It has no current users, and
it will not be used in the future.

This reverts commit 18b957a.

Signed-off-by: Andy Sadler <[email protected]>
@sadlerap sadlerap force-pushed the remove-konflux-workspaces-profile branch from 7313d78 to def5512 Compare April 16, 2024 20:49
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link
Contributor

/test remaining-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

@sadlerap: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security def5512 link false /test security
ci/prow/e2e def5512 link true /test e2e
ci/prow/validate-prow def5512 link true /test validate-prow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2024
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmguzik jmguzik Awaiting requested review from jmguzik

@psalajova psalajova Awaiting requested review from psalajova

Assignees

@psalajova psalajova

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sadlerap @psalajova @openshift-ci-robot @openshift-merge-robot @openshift-bot