Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the multi-arch pipeline to the pipeline config #977

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

arewm
Copy link
Contributor

@arewm arewm commented Aug 21, 2024

With konflux-ci/build-definitions#1236, we started building a multi-arch pipeline. This change adds it to the config map so that it can be used for configuring components.

Fixes

Description

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot requested review from jrichter1 and Katka92 August 21, 2024 15:18
With konflux-ci/build-definitions#1236, we
started building a multi-arch pipeline. This change adds it to the
config map so that it can be used for configuring components.

Signed-off-by: arewm <[email protected]>
@arewm arewm force-pushed the add-multi-arch-pipeline branch from 30e71e7 to 82b1f23 Compare August 21, 2024 15:19
Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@rcerven: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (66b2184) to head (82b1f23).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files         580      580           
  Lines       14043    14043           
  Branches     3926     3926           
=======================================
  Hits        11859    11859           
  Misses       2053     2053           
  Partials      131      131           
Files Coverage Δ
.../ImportForm/PipelineSection/usePipelineTemplate.ts 80.95% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b2184...82b1f23. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

@arewm: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@abhinandan13jan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arewm, rcerven, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3300e6c into openshift:main Aug 21, 2024
7 checks passed
@arewm arewm deleted the add-multi-arch-pipeline branch August 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants