Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow to avoid deprecated commands #1406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MaxineMuster
Copy link
Contributor

@DeDaMrAzR
Copy link
Contributor

@MaxineMuster

There are more complications than it meets the eye in there :)

upload-artifact@v4 is implicitly creating ZIP archives for every artifact so there has to be a extract and then merge so we get the exact same output for publishing or we must change the releaserc.yaml to accommodate the changes.

See some of my experiments here - https://github.com/DeDaMrAzR/OpenBK7231T_App/actions/runs/11516737538

You can test there as much as you want so we can perfect the solution and then move it over to main.

@DeDaMrAzR
Copy link
Contributor

I've also updated the latest for simulator build so no warning are now present but I don't have enough time to finish that - nor knowledge 😊

@MaxineMuster
Copy link
Contributor Author

MaxineMuster commented Oct 29, 2024

upload-artifact@v4 is implicitly creating ZIP archives for every artifact so there has to be a extract and then merge so we get the exact same output for publishing or we must change the releaserc.yaml to accommodate the changes.

Yes, I'm aware of that, and I know this way we will get one zip file per platform during build, e.g. in PRs, instead of one single zip including all files. But to be honest, I think this can be seen both as an advantage and a disadvantage.

And I won't pretend I totally understand all this, but as far as I understood, there is no need to change releaserc.yaml, for download-artifact seems to be aware of that.

So, as I said, only tested once, a release seems to work exactly as before:

https://github.com/Max4OBK/OpenBK7231T_App/releases/tag/1.0.1

@DeDaMrAzR
Copy link
Contributor

You inspired me to dedicate my time (probably stealing it from my sleep time) to this and I will add the final solution in the next 15-20 minutes.

Thank you for pushing me to do this 😉

@MaxineMuster
Copy link
Contributor Author

You're welcome ;-) ;-)!
Sorry for doing so, it was just curiosity, and I learned something new again, I would never have looked at before...

Thanks for bringing this into a working state!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants