Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LN882H WS2811 Driver #1414

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jasperro
Copy link

@jasperro jasperro commented Nov 4, 2024

This PR is related to https://www.elektroda.com/rtvforum/topic4083817.html

It implements WS2811 support for the LN882H platform.

I will still be adding some documentation and the ability to change the data pin using a pin role, after which I will unmark this as draft.

Split out LN882H pin mapping to its own header file

Enable color control from the web interface

Remove WS2811_Multiplex command as this is unneeded.
@jasperro jasperro force-pushed the jasperroLN882H-WS2811 branch 2 times, most recently from 7463f0b to eec0da7 Compare November 7, 2024 22:24
Add comments and generate docs

Tabs to spaces, char/byte to uint8_t, reorder functions

Use IOR_WS2811_DIN pin role to set WS2811 data pin
@jasperro jasperro marked this pull request as ready for review November 7, 2024 22:42
@jasperro jasperro changed the title Draft: LN882H WS2811 Driver LN882H WS2811 Driver Nov 7, 2024
@jasperro
Copy link
Author

jasperro commented Nov 7, 2024

I think this one is about ready. Before merging, it is needed that openshwprojects/OpenLN882H#19 is merged. The .gitmodules file and modules can then point to the main OpenLN882H repo again.

Small note: it seems there is a small issue in the Makefile introduced/which got influenced by the ESP-IDF changes, which made it impossible to build locally using the docker image. Locally, I changed the line under the .PHONY submodule from git submodule update --init --recursive --remote to git submodule update --init --recursive, after which I could build again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant