Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the sticky bottom padding in the profile screen #3590

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed the sticky bottom padding in the profile screen #3590

wants to merge 2 commits into from

Conversation

Aleem92
Copy link
Contributor

@Aleem92 Aleem92 commented Nov 5, 2024 •
edited
Loading

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 27.6%. Comparing base (8ee171a) to head (dd01089).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...egister/fhircore/quest/ui/profile/ProfileScreen.kt 0.0% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3590     +/-   ##
=========================================
+ Coverage     27.3%   27.6%   +0.2%     
+ Complexity     787     784      -3     
=========================================
  Files          282     281      -1     
  Lines        14699   14430    -269     
  Branches      2634    2583     -51     
=========================================
- Hits          4023    3990     -33     
+ Misses       10132    9897    -235     
+ Partials       544     543      -1
Flag Coverage Δ
engine 63.8% <ø> (ø)
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...egister/fhircore/quest/ui/profile/ProfileScreen.kt 0.0% <0.0%> (ø)

... and 14 files with indirect coverage changes

@Aleem92 Aleem92 added the Draft label Nov 5, 2024
@Aleem92 Aleem92 self-assigned this Nov 5, 2024
@Aleem92 Aleem92 removed the Draft label Nov 6, 2024
@ellykits
Copy link
Collaborator

@Aleem92 Can you share screenshots with the padding applied with fab and when it's not?

@Aleem92
Copy link
Contributor Author

Aleem92 commented Nov 25, 2024

@Aleem92 Can you share screenshots with the padding applied with fab and when it's not?

@ellykits

Below is the screenshot of the profile before fixing the padding issue:
Screenshot_1732535997

Here is the screenshot of the profile after the padding issue was fixed using this PR:
Screenshot_1732536675

Additionally, here is the view with fabActions:
Screenshot_1732538865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aleem92 Aleem92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the sticky bottom padding in the profile screen
3 participants
@Aleem92 @ellykits @allan-on