Enable dark mode attribution font color #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the specificity of the dark mode attribution selector. This makes it overwrite Leaflet's default link selector.
|
This was supposed to be working already #4764 but something broke it. |
|
The specificity is the same as in Leaflet css, then it depends on the order but I don't see where we changed the order. It would have been in |
|
It's probably Sass's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR increases the specificity of the dark mode attribution selector. The style was first added in #4764, but didn't overwrite Leaflet's default link selector. That increased specificity fixes #5329's bug report about this by @Nekzuris