Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connected to platform with insecure TLS certs (i.e. self-signed), CLI should provide better context #407

Open
jakedoublev opened this issue Oct 22, 2024 · 0 comments

Comments

@jakedoublev
Copy link
Contributor

Background

At present, if connected to a platform running with insecure self-signed certs or over http, the CLI will report Failed to get platform configuration. Is the platform accepting connections at '$HOST'? when using client credentials, or ERROR An error occurred during login. Please check your credentials and try again: platform configuration not found when trying to directly authenticate the profile through client credentials.

These errors are misleading, as the true error is that the well-known config is available but the cert failed. This is due to logic here:

if errors.Is(err, auth.ErrPlatformConfigNotFound) {

We should check if the reason the SDK errored out was due to not passing --tls-no-verify and instruct the CLI user helpfully about the situation.

Acceptance Criteria

  1. CLI should check for a failed connection due to a TLS issue
  2. CLI should report on the failed TLS connection and warn the user that they may need to insecurely skip TLS verification
  3. e2e test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant