Feat/distributed state/childkey updates #2134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distributedstatemachine
changed the base branch from
master
to
feature/opendansor/child_hotkeys
distributedstatemachine
requested review from
opendansor,
roman-opentensor and
thewhaleking
arslan-ot
reviewed
Jul 17, 2024
| success, message = subtensor.revoke_children( | ||
| # Get current children | ||
| current_children = subtensor.get_children_info(netuid=netuid) | ||
| if ( |
There was a problem hiding this comment.
More of a suggestion; it might be better to write this if condition as:
if not current_children or not current_children.get(cli.config.hotkey, False):
roman-opentensor
requested changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR