-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/batch set weights #1022
Merged
Merged
Feat/batch set weights #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hotfix
This PR needs to be merged very quickly and will likely skip testing on devnet and testnet
label
Nov 26, 2024
5 tasks
camfairchild
removed
the
hotfix
This PR needs to be merged very quickly and will likely skip testing on devnet and testnet
label
Nov 26, 2024
gztensor
reviewed
Nov 27, 2024
gztensor
previously approved these changes
Nov 27, 2024
5 tasks
gztensor
previously approved these changes
Dec 6, 2024
sam0x17
previously approved these changes
Dec 6, 2024
sam0x17
added
the
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
label
Dec 6, 2024
camfairchild
commented
Dec 6, 2024
camfairchild
commented
Dec 6, 2024
camfairchild
commented
Dec 6, 2024
camfairchild
commented
Dec 6, 2024
camfairchild
commented
Dec 6, 2024
camfairchild
commented
Dec 6, 2024
sam0x17
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with batching weights having an increased fee from: paritytech/polkadot-sdk#5644
This adds both
batch_set_weights
andbatch_commit_weights
Support added to bittensor in opentensor/bittensor#2485
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.