Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/batch set weights #1022

Merged
merged 23 commits into from
Dec 6, 2024
Merged

Feat/batch set weights #1022

merged 23 commits into from
Dec 6, 2024

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Nov 26, 2024

Description

Fixes an issue with batching weights having an increased fee from: paritytech/polkadot-sdk#5644

This adds both batch_set_weights and batch_commit_weights

Support added to bittensor in opentensor/bittensor#2485

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@camfairchild camfairchild changed the base branch from main to devnet-ready November 26, 2024 18:58
@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Nov 26, 2024
@camfairchild camfairchild linked an issue Nov 26, 2024 that may be closed by this pull request
5 tasks
@camfairchild camfairchild marked this pull request as ready for review November 26, 2024 22:57
@camfairchild camfairchild removed the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Nov 26, 2024
gztensor
gztensor previously approved these changes Nov 27, 2024
@camfairchild camfairchild requested a review from gztensor December 5, 2024 23:06
gztensor
gztensor previously approved these changes Dec 6, 2024
sam0x17
sam0x17 previously approved these changes Dec 6, 2024
@sam0x17 sam0x17 dismissed stale reviews from gztensor and themself via 9efedff December 6, 2024 04:43
@opentensor opentensor deleted a comment from github-actions bot Dec 6, 2024
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Dec 6, 2024
@sam0x17 sam0x17 merged commit e44fbf6 into devnet-ready Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add batched extrinsics for setting weights
3 participants