Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage with Angular #139

Open
dzag opened this issue Apr 29, 2020 · 2 comments · May be fixed by #140
Open

Usage with Angular #139

dzag opened this issue Apr 29, 2020 · 2 comments · May be fixed by #140

Comments

@dzag
Copy link

dzag commented Apr 29, 2020

I'm using the library to do some network tests but I'm noticing that the library isn't using native Promise which will be a problem in an Angular app.

Without using native Promise, I couldn't opt out of Angular Zone and it makes the app unusable due to detectChanges has been called a lot when running network testing.

I have a PR for the issue.
@dzag dzag linked a pull request Apr 29, 2020 that will close this issue
Open
@a7md3bdelfatta7
Copy link

which angular version you are using? i am trying to add it to angular 9 project and i got this error

This likely means that the library which declares NetworkTest has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

@dzag
Copy link
Author

dzag commented Sep 2, 2020

which angular version you are using? i am trying to add it to angular 9 project and i got this error

This likely means that the library which declares NetworkTest has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

You should recompile your project and let ngcc process the library in order to use it, that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Should use native Promise when possible dzag/opentok-network-test-js
2 participants
@dzag @a7md3bdelfatta7