-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removing dependancy for node-requests #311
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests in opentok_spec.js are failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests are failing: #311 (review).
Also, please rev the version (to 2.17.0) in package.json and package-lock.json.
This should only be requested once the PR is ready to merge in. Otherwise the PR will always be rejected as we paly whack-a-mole with the release versions |
These failures are inconsistent and intermittent. I am not familiar with these tests or how to resolve them. The reason for asking for your review on this PR is because there is not full coverage for all use cases with the SDK. Any guidance from you would be helpful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
15 tests are failing ("Archiving listArchives should return an array of archives and a total count" and 14 others).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I install packages, I am alerted the get-func-name
is audited with "high" vulnerability. And @babel/traverse
is flagged as being critical. Can we update chai and nyc to update these sub-packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to rev the version of the library (to 2.16.1) in the package.json and package-lock.json files.
0929b25
to
26ef9e4
Compare
894f350
to
5b77151
Compare
5b77151
to
3c4d674
Compare
30a0013
to
a3a4b34
Compare
if (response && response.statusCode === 404) { | ||
try { | ||
body = JSON.parse(body); | ||
} catch {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter complains that this (and other instances of catch {}
) results in a parsing error. (Replace with catch (error) { }
).
There are already existing linting errors in the main branch. But if you add /* eslint-env es2018 */
to the top of this file, you will see more linting errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rev the version (to 2.17.0) in package.json and package-lock.json. (I assume we are ready to release this.)
This PR removes the 'requests' package, which has not been updated in over 6 years and has major security errors.