Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process boarding location for linear platforms #6247

Open
wants to merge 6 commits into
base: dev-2.x
Choose a base branch
from

Conversation

miklcct
Copy link
Contributor

@miklcct miklcct commented Nov 11, 2024

Summary

This adds the processing of boarding locations on linear platforms.

Explain in one or two sentences what this PR achieves.
Fixes #6056

Unit tests

TBC

Documentation

None

Bumping the serialization version id

Required. A new class is added into the graph.

@t2gran t2gran added this to the 2.7 (next release) milestone Nov 12, 2024
@leonardehrenfried
Copy link
Member

leonardehrenfried commented Nov 12, 2024

We talked about this today and we came to the conclusion that we want to introduce a data structure that is available during graph build only and then discarded. Lets discuss this in a meeting.

@miklcct
Copy link
Contributor Author

miklcct commented Nov 12, 2024

Does moving the LinearPlatform field into StreetEdge and marking it as transient achieve the above, and avoid a serialisation bump?

@leonardehrenfried
Copy link
Member

Unfortuntately not. We want to design a new system for keeping information that is used during graph build only and then discarded.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 69.78%. Comparing base (684b841) to head (b445ab8).
Report is 1 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...aph_builder/module/OsmBoardingLocationsModule.java 42.85% 19 Missing and 5 partials ⚠️
.../opentripplanner/routing/linking/VertexLinker.java 57.14% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6247      +/-   ##
=============================================
- Coverage      69.79%   69.78%   -0.01%     
- Complexity     17786    17800      +14     
=============================================
  Files           2017     2020       +3     
  Lines          76042    76098      +56     
  Branches        7781     7784       +3     
=============================================
+ Hits           53073    53108      +35     
- Misses         20264    20285      +21     
  Partials        2705     2705              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miklcct miklcct marked this pull request as ready for review December 5, 2024 15:54
@miklcct miklcct requested a review from a team as a code owner December 5, 2024 15:54
@habrahamsson-skanetrafiken
Copy link
Contributor

@t2gran will come with some suggestions of how to solve this without adding anything to the serialized graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boardinglocations on ways don't seem to work as expected
4 participants