Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'bogusName' to 'nameIsDerived' #6333

Open
wants to merge 2 commits into
base: dev-2.x
Choose a base branch
from

Conversation

leonardehrenfried
Copy link
Member

Summary

As a follow-up to my previous bogus name PR, this renames the internal uses of "has bogus name" to "name is derived".

@abyrd @habrahamsson-skanetrafiken I've taken the liberty to ask for your review. This is absolutely low priority but let me know if you don't want to do it.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.81%. Comparing base (ae85810) to head (4c6db7f).
Report is 1 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...builder/module/osm/naming/PortlandCustomNamer.java 0.00% 3 Missing ⚠️
...pplanner/inspector/raster/PathwayEdgeRenderer.java 0.00% 1 Missing ⚠️
...nner/inspector/vector/edge/EdgePropertyMapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6333      +/-   ##
=============================================
- Coverage      69.82%   69.81%   -0.01%     
+ Complexity     17830    17828       -2     
=============================================
  Files           2021     2021              
  Lines          76250    76250              
  Branches        7802     7802              
=============================================
- Hits           53238    53237       -1     
- Misses         20297    20298       +1     
  Partials        2715     2715              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants