UCP/GTEST: Workaround KSM ODP failure #10328
Open
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Nov 26, 2024
Artemy-Mellanox
force-pushed
the
topic/war-ksm-odp
branch
from
47529cf
to
6c564cc
Compare
brminich
reviewed
Nov 29, 2024
Comment on lines
+337
to
+340
| if (md->config.enable_atomic_offset) { | ||
| return md->flush_rkey >> 8; | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
seems it breaks remote flush functionality UCT_FLUSH_FLAG_REMOTE (e.g. see uct_dc_mlx5_flush_remote_rkey)
There was a problem hiding this comment.
in this PR it's not a problem since param is on by default, but in future if we make it off or auto will need to handle this
There was a problem hiding this comment.
Yes, but this PR introduces new env var, tweaking which may result in a failure.
Maybe just temprorarily disable the tests instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Temporary disable shifted atomic address in ODP PUT tests.
Why?
Shifted atomic address exposes an issue in the driver (RM 4170682).