Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create some initial tests #114

Open
6 of 11 tasks
waldoj opened this issue Feb 22, 2017 · 2 comments
Open
6 of 11 tasks

Create some initial tests #114

waldoj opened this issue Feb 22, 2017 · 2 comments
Labels
enhancement

Comments

@waldoj
Copy link
Member

waldoj commented Feb 22, 2017 •
edited
Loading

Some end-to-end tests are the best way to start.

  • the API returns a bill record
  • the API returns a legislator record
  • the API returns a tag on a bill
  • the front-end shows a bill
  • the front-end shows a legislator record
  • the front-end shows a tag on a bill
  • the front-end shows poll results
  • the front-end shows a comment on a bill

Then put them to work.

  • have Travis CI stand up the site in Docker
  • execute tests
  • gate deployment based on outcome of tests
@waldoj waldoj changed the title Create some tests Create some live tests Jul 29, 2017
waldoj added a commit that referenced this issue Dec 29, 2018
@waldoj
Include PHPUnit
03d5766 
This is a tiny step toward #114. This code is terrifically untestable — every method is end-to-end, seemingly every method requires a live database connection — but here's a stake in the ground.
waldoj added a commit that referenced this issue Jun 15, 2019
@waldoj
All several front-end tests
bf38371 
Toward #114.
waldoj added a commit that referenced this issue Jun 15, 2019
@waldoj
Create a script that runs all tests
c91b7a5 
Toward #114.
@waldoj waldoj changed the title Create some live tests Create some initial tests Jun 15, 2019
waldoj added a commit that referenced this issue Jun 18, 2019
@waldoj
Run all tests, report when they fail
3f1f760 
Before we were ending testing when getting an error. Now all tests complete. Toward #114.
waldoj added a commit that referenced this issue Jun 18, 2019
@waldoj
Add more e2e tests
f5e34d3 
Test bill comments, poll results, outcomes, and histories. Toward #114.
waldoj added a commit that referenced this issue Jun 19, 2019
@waldoj
Add a legislator endpoint test
50f0e5b 
Toward #114.
waldoj added a commit that referenced this issue Jun 19, 2019
@waldoj
Run tests in CI/CD
e2434ba 
Toward #114.
waldoj added a commit that referenced this issue Jun 19, 2019
@waldoj
Switch to terse error checking in tests
b88d48c 
Toward #114.
waldoj added a commit that referenced this issue Jun 19, 2019
@waldoj
Handle directory context for test runner
c9e3fa0 
Toward #114.
waldoj added a commit that referenced this issue Jun 19, 2019
@waldoj
Remove Docker functionality from CI/CD
d92eebb 
I thought I'd see if it would Just Work. It does not. I get this error:

ERROR 2003 (HY000): Can't connect to MySQL server on 'rs_db' (111 "Connection refused")

Seems I've got some work to do.

Toward #114.
@waldoj
Copy link
Member Author

waldoj commented Jun 19, 2019

I thought I'd just throw ./docker-run.sh into the Travis CI config, to see if it worked. It almost did, but then it failed with this:

ERROR 2003 (HY000): Can't connect to MySQL server on 'rs_db' (111 "Connection refused")

Looks like I can't just use that as is. I imagine I need to use Travis’s MySQL functionality.

This might be a good cue to move to CircleCI.

@waldoj waldoj mentioned this issue Nov 12, 2019
Open
@waldoj
Copy link
Member Author

waldoj commented Nov 12, 2019

Blocked by #346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@waldoj