Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KITTI tracklet h, w fields swapped #1578

Open
playertr opened this issue Aug 1, 2024 · 1 comment
Open

KITTI tracklet h, w fields swapped #1578

playertr opened this issue Aug 1, 2024 · 1 comment
Assignees

Comments

@playertr
Copy link

playertr commented Aug 1, 2024

In the KITTI exporter at line 342, the h and w attributes are swapped so that they correspond the the second and first elements, respectively, of the Cuboid3D scale attribute:

track = {
                        "objectType": label,
                        "h": ann.scale[1],
                        "w": ann.scale[0],
                        "l": ann.scale[2],
                        "first_frame": frame_id,
                        "poses": [],
                        "finished": 1,  # keep last
                    }

This corresponds to the re-ordering [sy, sx, sz] with respect to the definitions from the Cuboid3D class definition.

However, this appears to be inconsistent with the definition from Geiger, 2013, p. 3, which says that length corresponds to the "x" axis of the tracklet.

Screenshot from 2024-08-01 15-49-40

Is this inconsistency expected? I needed to re-swap these dimensions when using the labels.

@wonjuleee
Copy link
Contributor

Hi @playertr, you are correct. From the KITTI officials, they described as below.
image

So we fixed this at #1596 and this will be published as 1.9.0 soon!

wonjuleee added a commit that referenced this issue Sep 2, 2024
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary

- Fix for #1578

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [ ] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [x] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [ ] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants