Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashcat mode rules for character class support #5553

Open
solardiz opened this issue Nov 2, 2024 · 1 comment
Open

Update hashcat mode rules for character class support #5553

solardiz opened this issue Nov 2, 2024 · 1 comment

Comments

@solardiz
Copy link
Member

solardiz commented Nov 2, 2024

Once hashcat/hashcat#4107 is merged, we'll need to enable our class support in the purge command also in hashcat mode. It is currently disabled with the check here:

#define CLASS_export_pos(start, true, false) { \
        char value, *class; \
        if (((value = RULE) == '?') && !hc_logic) { \

This may be a bit complicated because:

  1. It looks like hashcat is currently only adding class support to this one command, whereas we use the same macro for many commands.
  2. hashcat will likely add exceptions where @? followed by some characters found in existing rulesets is treated the same as @??. We'll likely want to mimic those exceptions when in hashcat mode (or we'll need to update our copies of hashcat style rulesets to use @?? where appropriate - it's just 3 places).
@solardiz solardiz added this to the Definitely 2.0.0 milestone Nov 2, 2024
@solardiz solardiz changed the title Update hashcat mode rules for purge class command support Update hashcat mode rules for character class support Nov 2, 2024
@solardiz
Copy link
Member Author

solardiz commented Nov 2, 2024

The referenced hashcat pull request has changed a lot since I posted the original description of this issue. It isn't yet clear what will actually go into hashcat, and thus what changes we need to make here, but now it looks likely that hashcat will implement character classes not only for the purge command, but for most or all commands where we support character classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant