Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require execution engines to support http(s) URLs in File declaration expressions #679

Open
jdidion opened this issue Jul 26, 2024 · 1 comment

Comments

@jdidion
Copy link
Collaborator

jdidion commented Jul 26, 2024

Currently, expressions in File declarations are required to evaluate to a path in the execution environment. We want to move away from allowing relative paths, so really the only use case for an expression in a file declaration is to specify an absolute path in the execution environment, which has limited utility.

It seems like a much more useful purpose for file declaration expressions would be to allow for localizing remotely available (public) resources. At a minimum we should require engines to support public http(s) URLs (i.e., not requiring authentication). We already require engines to support http(s) for imports so this doesn't seem like it would be a huge burden to put on engine developers.

@patmagee
Copy link
Member

I think practically this makes a lot of sense, however I definitely know of cases where this would not be allowed (ie violataes service boundaries or environments cut off from external networks). Additionally, you may want to control where inputs are coming from to prevent external resources entering into a protected environment.

So far we have been fairly un-opinionated about the types of files an engine needs to support and have dealt largely in the abstract. Overall, I think this has served us well so I am hesitant to mandate support for a specific format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants