Update numerical methods #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
force-pushed
the
update-numerical-methods
branch
3 times, most recently
from
91b543e to
314518b
Compare
pstaabp
force-pushed
the
update-numerical-methods
branch
from
314518b to
791f6e5
Compare
pstaabp
force-pushed
the
update-numerical-methods
branch
2 times, most recently
from
e361d8c to
bea9cba
Compare
pstaabp
force-pushed
the
update-numerical-methods
branch
from
bea9cba to
16d7915
Compare
|
There's a lot to review here. Would it be hard to cut this into separate PRs? The first one could just get code cleanup out of the way without the tests or the new tools. Or something like that. |
|
@Alex-Jordan I can do that. Would you like separate PRs. Or separate commits? I could split either way to 1) code cleanup and then 2) new functionality. |
drgrice1
reviewed
Feb 13, 2024
| BEGIN { | ||
| be_strict(); | ||
| } | ||
| BEGIN { strict->import; } |
There was a problem hiding this comment.
This is already on line 42 below. One of these needs to be removed.
|
PR #1022 now has this without any of the new code. I will close this one soon. |
|
closing in favor of #1022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some functionality to the macro
PGnumericalmacros.plas well as includes a test suite for the macro. Also, cleaned up the code and improved the documentation.Can provide some problems if needed.