Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the webwork2 and PG localizations. PG now uses its own translation po and pot files and provides its own language handle for maketext. Only the language is passed in by the caller.
The translations in the PG code have been transferred from webwork2.
Note that this includes the fixes for using
maketext
inside the safe compartment that were in the now closed openwebwork/webwork2#2213.That is the
_compile
method ofLocale::Maketext
is overridden to remove theuse strict
usage inside of its code eval call. That is the only essential difference between the override method added here and the original method inLocale::Maketext
. With this you can usemaketext
interpolation in PG. For example, you can callmaketext('[quant,_1,dog] ate my homework', $num_dogs)
.