Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug/qa] Lint errors are ignored #485

Open
nemesifier opened this issue Aug 4, 2024 · 0 comments
Open

[bug/qa] Lint errors are ignored #485

nemesifier opened this issue Aug 4, 2024 · 0 comments
Labels

Comments

@nemesifier
Copy link
Member

Lint errors are ignored:
https://github.com/openwisp/ansible-openwisp2/blob/master/molecule/local/molecule.yml#L9-L12

This was probably forgotten.

We need to move those checks from there to the run-qa-checks script, if there's no run-qa-checks script, we must add one like we have in other repos.
We also need to make sure failing QA checks do not stop the entire build as we did in other modules, eg: openwisp/openwisp-controller@5fff20c (double check the latest version of the file for the latest optimal configuration).

We must not ignore failures and we must fix all the linting issues that are currently affecting this role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do (general)
Development

No branches or pull requests

1 participant