Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Extract dependencies from pip.yml to requirements.txt for Dependabot compatibility #509

Closed
wants to merge 2 commits into from

Conversation

aadi-joshi
Copy link

@aadi-joshi aadi-joshi commented Nov 28, 2024

Extract dependencies from pip.yml to requirements.txt for Dependabot compatibility.

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #507.

Description of Changes

  • Moved Dependencies from pip.yml to requirements.txt
  • Updated pip.yml and removed all package dependencies from it
  • Referenced requirements.txt in pip.yml
  • Created a requirements.txt
  • Fixed Invalid Requirements in requirements.txt
  • Added dependabot.yml Configuration

Screenshot

image
pip install -r requirements.txt works successfully.
dependabot.yml also made with an interval of daily.

@nemesifier nemesifier changed the title [Enhance]: Extract dependencies from pip.yml to requirements.txt for Dependabot compatibility [change] Extract dependencies from pip.yml to requirements.txt for Dependabot compatibility Nov 28, 2024
tags:
- molecule-idempotence-notest
dependencies:
- "-r ../requirements.txt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incomplete. The build is failing. Have you tested this?

Copy link
Author

@aadi-joshi aadi-joshi Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i run molecule test -s ubuntu2004, this is what the terminal shows.

WARNING  The scenario config file ('/mnt/d/..repo clones/org_ansible-openwisp2/molecule/ubuntu2004/molecule.yml') has been modified since the scenario was created. If recent changes are important, reset the scenario with 'molecule destroy' to clean up created items or 'molecule reset' to clear current configuration.
INFO     ubuntu2004 scenario test matrix: dependency, cleanup, destroy, syntax, create, prepare, converge, idempotence, side_effect, verify, cleanup, destroy
INFO     Performing prerun with role_name_check=0...
INFO     Running ubuntu2004 > dependency
WARNING  Skipping, missing the requirements file.
WARNING  Skipping, missing the requirements file.
INFO     Running ubuntu2004 > cleanup
WARNING  Skipping, cleanup playbook not configured.
INFO     Running ubuntu2004 > destroy

PLAY [Destroy] *****************************************************************

TASK [Populate instance config] ************************************************
ok: [localhost]

TASK [Dump instance config] ****************************************************
skipping: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0    skipped=1    rescued=0    ignored=0

INFO     Running ubuntu2004 > syntax

playbook: /mnt/d/..repo clones/org_ansible-openwisp2/molecule/ubuntu2004/converge.yml
INFO     Running ubuntu2004 > create

PLAY [Create] ******************************************************************

TASK [Populate instance config dict] *******************************************
skipping: [localhost]

TASK [Convert instance config dict to a list] **********************************
skipping: [localhost]

TASK [Dump instance config] ****************************************************
skipping: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=0    changed=0    unreachable=0    failed=0    skipped=3    rescued=0    ignored=0

INFO     Running ubuntu2004 > prepare
WARNING  Skipping, prepare playbook not configured.
INFO     Running ubuntu2004 > converge

PLAY [Converge] ****************************************************************

TASK [Replace this task with one that validates your content] ******************
ok: [instance] => {
    "msg": "This is the effective test"
}

PLAY RECAP *********************************************************************
instance                   : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

INFO     Running ubuntu2004 > idempotence

PLAY [Converge] ****************************************************************

TASK [Replace this task with one that validates your content] ******************
ok: [instance] => {
    "msg": "This is the effective test"
}

PLAY RECAP *********************************************************************
instance                   : ok=1    changed=0    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

INFO     Idempotence completed successfully.
INFO     Running ubuntu2004 > side_effect
WARNING  Skipping, side effect playbook not configured.
INFO     Running ubuntu2004 > verify
INFO     Running Ansible Verifier
WARNING  Skipping, verify action has no playbook.
INFO     Verifier completed successfully.
INFO     Running ubuntu2004 > cleanup
WARNING  Skipping, cleanup playbook not configured.
INFO     Running ubuntu2004 > destroy

PLAY [Destroy] *****************************************************************

TASK [Populate instance config] ************************************************
ok: [localhost]

TASK [Dump instance config] ****************************************************
skipping: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0    skipped=1    rescued=0    ignored=0

INFO     Pruning extra files from scenario ephemeral directory

could you help me out with how to test for build fail and how to fix the issues?

@nemesifier
Copy link
Member

This PR is just wrong. I suggest to pick up another issue to work on. I don't have time to train you on this now.

@nemesifier nemesifier closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Use dependabot to upgrade dependencies in pip.yml
2 participants