From 131d5e5e3b53a24722c6b9a46e6a34c6b44995b1 Mon Sep 17 00:00:00 2001
From: Dhanus <dhanus3133@gmail.com>
Date: Tue, 23 Jul 2024 22:30:07 +0530
Subject: [PATCH] [ci] Run tests also if QA checks fail

---
 .github/workflows/ci.yml | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 327948e..6af0f95 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -35,17 +35,12 @@ jobs:
       with:
         python-version: ${{ matrix.python-version }}
 
-    - name: Install python dependencies
-      run: pip install -U "pip==20.2.4" setuptools wheel
-
-    - name: Install npm dependencies
-      run: sudo npm install -g jslint
-
-    - name: Install test dependencies
-      run: pip install -U -r requirements-test.txt
-
-    - name: Install django-x509
+    - name: Install Dependencies
+      id: deps
       run: |
+        pip install -U "pip==20.2.4" setuptools wheel
+        sudo npm install -g jslint
+        pip install -U -r requirements-test.txt
         pip install -U -e .
         pip install ${{ matrix.django-version }}
 
@@ -53,11 +48,13 @@ jobs:
       run: ./run-qa-checks
 
     - name: Tests
+      if: ${{ !cancelled() && steps.deps.conclusion == 'success' }}
       run: |
         coverage run --source=django_x509 runtests.py
         SAMPLE_APP=1 ./runtests.py --parallel --keepdb
 
     - name: Upload Coverage
+      if: ${{ success() }}
       run: coveralls --service=github
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}