Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add hint to use check-commit and openwisp-qa-format #99

Closed
nemesifier opened this issue Apr 6, 2020 · 1 comment · Fixed by #101
Closed

[docs] Add hint to use check-commit and openwisp-qa-format #99

nemesifier opened this issue Apr 6, 2020 · 1 comment · Fixed by #101
Labels
enhancement

Comments

@nemesifier
Copy link
Member

We're adding openwisp-qa-format and a way to force the commit message check in openwisp/openwisp-utils#89, we should update the docs to mention these two tools and suggest their usage.
PabloCastellano added a commit to PabloCastellano/openwisp2-docs that referenced this issue Apr 6, 2020
@PabloCastellano
[contributions] Mention black and openwisp-qa-format openwisp#99
b697b16 
Black has been recently added to our suite of tools to check code conventions.
Also, a new script `openwisp-qa-format` is provided in openwisp-utils to
format the code according to the expected code conventions.

Fixes openwisp#99
@PabloCastellano PabloCastellano mentioned this issue Apr 6, 2020
Merged
@PabloCastellano
Copy link
Contributor

I have sent a PR that mentions black and the new openwisp-qa-format script

I haven't explained a way to force the commit message check, will do it in #100

PabloCastellano added a commit to PabloCastellano/openwisp2-docs that referenced this issue Apr 6, 2020
@PabloCastellano
[contributions] Mention black and openwisp-qa-format openwisp#99
c7537ce 
Black has been recently added to our suite of tools to check code conventions.
Also, a new script `openwisp-qa-format` is provided in openwisp-utils to
format the code according to the expected code conventions.

Fixes openwisp#99
nemesifier pushed a commit that referenced this issue Jun 4, 2020
@PabloCastellano
[contributions] Mention black and openwisp-qa-format #99 (#101)
e05f120 
* [contributions] Mention black and openwisp-qa-format #99

Black has been recently added to our suite of tools to check code conventions.
Also, a new script `openwisp-qa-format` is provided in openwisp-utils to
format the code according to the expected code conventions.

Fixes #99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
OpenWISP Contributor's Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[contributions] Mention black and openwisp-qa-format #99 PabloCastellano/openwisp2-docs
2 participants
@PabloCastellano @nemesifier