Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add device recognition mechanism #165

Open
nemesifier opened this issue Dec 10, 2021 · 0 comments
Open

[feature] Add device recognition mechanism #165

nemesifier opened this issue Dec 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@nemesifier
Copy link
Member

nemesifier commented Dec 10, 2021

Due to possible misconfiguration or bugs, in theory it's possible that the firmware upgrader could reflash the wrong device.

Since this is theoretically possible, we should add a mechanism which would be able to spot this case and prevent it from happening.

I immagine it as a method, which would have to be adapted for each upgrader backend, on OpenWRT we could simply check the uuid of the device in /etc/config/openwisp matches the UUID of the device currently being upgraded.

If the method spots this, it should raise an UpgradeAborted error but we must ensure the reason is clearly communicated to the user.

@nemesifier nemesifier added the enhancement New feature or request label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant