-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NHS Medicines A to Z #1138
Comments
Recipe created |
File is ready at the library |
Not ready, all top bar links are directly pointing to the online Web site. Can we do something about this recurring cookie banner? |
@kelson42 That's because we only scraped a subset of the top-level site I believe. |
@kelson42 we are scrapping only the medicine part, not all the website. |
Any reason to not hide the top bar then, if it only contains links to non-working parts, I see little reason to keep it? Only concern it that we have no more button/link to "home" if we remove the top links, but most readers have one, isn't it? And since we also scrape the "conditions" part in a different ZIM, do we really need to have two distinct ZIMs ? The medicine part seems to be only few 10s of MB, not something very concerning to justify being put aside, or do I miss something? |
OK then let's go for two ZIMS (but ZIM names will have to be fixed, see #1153). Not sure it is feasible, but what you should request me to do (from my own PoV, I'm clearly a silly person ^^) is to remove following zones in red: |
@benoit74 clearly you can do this for sure (Deleting the upper bar) |
Custom CSS created, recipe updated to publish to dev with this custom CSS and requested, let's see. |
I just realize this is very ambiguous. I proposed to delete far more than the upper bar. Current CSS deletes everything marked in red in my screenshot. |
LGTM ¯_(ツ)_/¯ |
I never realized there is a cookie banner. I'm a bit sad you did not insisted on this before. It is straightforward to remove for me. CSS updated and recipe launched again. |
@benoit74 the file looks perfect, I've pushed to library. |
File is ready at the library |
Your link is about conditions not medicines, and it is not updated with the proper CSS update to hide cookie banner and irelevant links |
File is now really ready in the library: https://library.kiwix.org/viewer#nhs.uk_en_medicines_2024-09 |
Pretty much a copy of #323
The text was updated successfully, but these errors were encountered: