Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChopinEarlyEditionsCollection by UniversityOfChicagoLibrary chopin.lib.uchicago.edu #604

Open
Rexadev opened this issue Apr 3, 2023 · 9 comments
Assignees
Labels
Entertainment Content related to Entertainment Zimit

Comments

@Rexadev
Copy link

Rexadev commented Apr 3, 2023

Please use the following format for a ZIM creation request (and delete unnecessary information)

  • Website URL: http://chopin.lib.uchicago.edu/
  • License: Public domain
  • Desired ZIM Title: Chopin Sheet Music - The Chopin Early Editions collection by University of Chicago Library
  • Desired ZIM Description: The Chopin collection at the University of Chicago Library includes over 400 first and early printed editions of musical compositions by Fr?d?ric Chopin, maintained in the Hanna Holborn Gray Special Collections Research Center. Because Chopin's works were often published concurrently in several countries with variant texts, scholars can establish a sequence of publication by comparing a range of printings. Chopin Early Editions consist of digitized images of all scores in the University of Chicago Library's Chopin collection. Users can search or browse Chopin Early Editions via a variety of data points, including titles, genres, and plate numbers.
  • Desired ZIM Icon –png (URL or attach one): https://example.com/example_icon.png
  • Language (ISO 639-3): eng
  • Is this a MediaWiki?: no
@Rexadev Rexadev changed the title New request: chopin.lib.uchicago.edu New request: The Chopin Early Editions collection by University of Chicago Library chopin.lib.uchicago.edu Apr 3, 2023
@RavanJAltaie RavanJAltaie added Entertainment Content related to Entertainment Zimit labels Jul 4, 2023
@Rexadev Rexadev changed the title New request: The Chopin Early Editions collection by University of Chicago Library chopin.lib.uchicago.edu [Request] ChopinEarlyEditionsCollection by UniversityOfChicagoLibrary chopin.lib.uchicago.edu Feb 22, 2024
@RavanJAltaie RavanJAltaie self-assigned this Apr 12, 2024
@RavanJAltaie
Copy link
Contributor

Recipe created
https://farm.openzim.org/recipes/chopin.lib.uchicago.edu_en_all
I'll update the library link once ready

@Rexadev Rexadev changed the title [Request] ChopinEarlyEditionsCollection by UniversityOfChicagoLibrary chopin.lib.uchicago.edu [RecipeCreated] ChopinEarlyEditionsCollection by UniversityOfChicagoLibrary chopin.lib.uchicago.edu Apr 13, 2024
@RavanJAltaie
Copy link
Contributor

Files Succeeded
https://dev.library.kiwix.org/viewer#chopin.lib.uchicago.edu_en_all_2024-04
but one link was not working because it re-directs to another website
https://www.lib.uchicago.edu/scrc/
I've added this URL to (Include) Parameter, @benoit74 is that correct?

@Rexadev
Copy link
Author

Rexadev commented Apr 30, 2024

https://www.lib.uchicago.edu/scrc/ also has other things
@RavanJAltaie

@benoit74
Copy link
Contributor

As @Rexadev said/confirm, we do not want to include the content of https://www.lib.uchicago.edu/scrc/ inside the ZIM, so adding them in the include list does not help at all.

These links which are broken should in fact lead to the online resource, so that when users are online they will be able to browse this link and when they are offline they will be presented with the regular browser saying something like "sorry we cannot access this page".

The fact that it is not displaying this message is a known zimit1 issue. I suggest to tag this as "upstream" and wait for zimit2 to solve the issue.

@RavanJAltaie RavanJAltaie added the Upstream For tickets which are waiting for an upstream modification (typically scrapper or target website) label Apr 30, 2024
@RavanJAltaie
Copy link
Contributor

@benoit74 I've removed the link from the include parameter.
Tagged the issue as upstream.

@benoit74
Copy link
Contributor

zimit2 achieved to create a pretty cool ZIM.

However there is at least two problems left to fix.

First if you go to https://dev.library.kiwix.org/viewer#chopin.lib.uchicago.edu_en_all_2024-09/chopin.lib.uchicago.edu/gsdl/cgi-bin/library%3Fe%3Dd-000-00---0chopin--00-0-0-0prompt-10---4---Document---0-1l--1-en-Zz-1---50-home---001-001-1-0utfZz-8-0%26a%3Dd%26cl%3DCL1.1%26d%3DCHOP124.1 and select another page in the combobox, it is not working ; navigating with prev/next works as expected ; this is an upstream bug, I will open an issue.

Image

Second the high res images have not been fetched while they are mostly essential ; we need to update the recipe configuration to also include http://www.lib.uchicago.edu/chopin/images/*.

Image

@Popolechien given the upstream bug will probably take time to fix and the combobox is not essential, we already have the next / prev links, shall we simply hide the combobox with CSS so that we can publish the ZIM? @Rexadev do you think the ZIM will still be usable without this combox box

@benoit74
Copy link
Contributor

Upstream issue is at openzim/warc2zim#409

@Popolechien
Copy link
Collaborator

LGTM

@benoit74 benoit74 assigned benoit74 and unassigned RavanJAltaie Oct 11, 2024
@benoit74 benoit74 changed the title [RecipeCreated] ChopinEarlyEditionsCollection by UniversityOfChicagoLibrary chopin.lib.uchicago.edu ChopinEarlyEditionsCollection by UniversityOfChicagoLibrary chopin.lib.uchicago.edu Oct 28, 2024
@benoit74 benoit74 removed Bug Something isn't working Upstream For tickets which are waiting for an upstream modification (typically scrapper or target website) labels Oct 28, 2024
@benoit74
Copy link
Contributor

I just fixed the CSS (I also hide search page which is not working / needed) and requested again in dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entertainment Content related to Entertainment Zimit
Projects
None yet
Development

No branches or pull requests

4 participants