-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChopinEarlyEditionsCollection by UniversityOfChicagoLibrary chopin.lib.uchicago.edu #604
Comments
Recipe created |
Files Succeeded |
https://www.lib.uchicago.edu/scrc/ also has other things |
As @Rexadev said/confirm, we do not want to include the content of https://www.lib.uchicago.edu/scrc/ inside the ZIM, so adding them in the include list does not help at all. These links which are broken should in fact lead to the online resource, so that when users are online they will be able to browse this link and when they are offline they will be presented with the regular browser saying something like "sorry we cannot access this page". The fact that it is not displaying this message is a known zimit1 issue. I suggest to tag this as "upstream" and wait for zimit2 to solve the issue. |
@benoit74 I've removed the link from the include parameter. |
zimit2 achieved to create a pretty cool ZIM. However there is at least two problems left to fix. First if you go to https://dev.library.kiwix.org/viewer#chopin.lib.uchicago.edu_en_all_2024-09/chopin.lib.uchicago.edu/gsdl/cgi-bin/library%3Fe%3Dd-000-00---0chopin--00-0-0-0prompt-10---4---Document---0-1l--1-en-Zz-1---50-home---001-001-1-0utfZz-8-0%26a%3Dd%26cl%3DCL1.1%26d%3DCHOP124.1 and select another page in the combobox, it is not working ; navigating with prev/next works as expected ; this is an upstream bug, I will open an issue. Second the high res images have not been fetched while they are mostly essential ; we need to update the recipe configuration to also include @Popolechien given the upstream bug will probably take time to fix and the combobox is not essential, we already have the next / prev links, shall we simply hide the combobox with CSS so that we can publish the ZIM? @Rexadev do you think the ZIM will still be usable without this combox box |
Upstream issue is at openzim/warc2zim#409 |
LGTM |
I just fixed the CSS (I also hide search page which is not working / needed) and requested again in dev. |
Please use the following format for a ZIM creation request (and delete unnecessary information)
The text was updated successfully, but these errors were encountered: