Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Zipkin browser extension use templates #1

Open
rtyler opened this issue Jul 16, 2015 · 0 comments
Open

Make Zipkin browser extension use templates #1

rtyler opened this issue Jul 16, 2015 · 0 comments

Comments

@rtyler
Copy link

rtyler commented Jul 16, 2015

(manually copying from openzipkin/zipkin#264 by @IceCreamYou)

As discussed in openzipkin/zipkin#261, the Zipkin browser extension currently renders the Firebug panel by directly constructing HTML. There's not a whole lot of HTML to construct, but it would be easier to maintain and audit for security if it was done using templates instead. Unfortunately we can't easily drop in something like Hogan because it has to execute in the Chrome context which doesn't have the same APIs available as the browser window. Firebug uses Domplate, which uses JS to build the DOM instead of HTML templates with substitutions, but that's annoyingly verbose. It's not clear to me what the canonical approach is for Firefox addons, if there is one, but it probably leans towards Domplate.

Using HTML-based templates is feasible, but will require a little work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant