Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic-release for easy releasing #45

Open
jcchavezs opened this issue Feb 17, 2018 · 5 comments
Open

Use semantic-release for easy releasing #45

jcchavezs opened this issue Feb 17, 2018 · 5 comments

Comments

@jcchavezs
Copy link

One day @adriancole said:

[...] I'd like to stop being the person who has to do everything

And I think he is right, we could have all this process automated by using semantic-release. In their own words, it solves the problem:

semantic-release automates the whole package release workflow including: determining the next version number, generating the release notes and publishing the package.
This removes the immediate connection between human emotions and version numbers, strictly following the Semantic Versioning specification.

I used it in a few projects at Typeform (how does it work?) and it worked and I believe zipkin-finagle could be a great first project to try this out.

Opinions?

@adriancole @openzipkin/devops-tooling

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Feb 18, 2018 via email

@abesto
Copy link
Member

abesto commented Feb 18, 2018

First time I hear about semantic-release; it looks like a great idea to me. To be clear, this means that when a maintainer approves a merge, they need to (a) be sure to check that the commit is correctly labeled for the change level (this is new) and (b) that merging triggers a release, there isn't an extra opportunity for a manual safety check – correct? Methinks these are way cheaper than manually releasing, so I'm all for trying it out.

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Feb 18, 2018 via email

@abesto
Copy link
Member

abesto commented Feb 20, 2018

I don't know about “main”, but the two other considerations for me are:

  • semantic-release seems to come with full-fledged release implementations; meaning we could possibly get rid of the long, complex bash scripts wrapping Maven
  • a point release on each relevant commit either (1) is overkill and noisy or (2) provides great cadence, allowing users to always get the latest and greatest, while also providing fine-grained control over what version / update level they want. This one's more philosophical, so whether it's a pro or a con, I'll leave to you :)

@codefromthecrypt
Copy link
Member

PS I've not really done many releases here until today :) I also think that this repo is a little more complicated than others, so if picking guinea pigs we can try another :D

@codefromthecrypt codefromthecrypt transferred this issue from openzipkin/zipkin-finagle Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants