Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 support #70

Open
codefromthecrypt opened this issue Jul 13, 2016 · 2 comments
Open

IPv6 support #70

codefromthecrypt opened this issue Jul 13, 2016 · 2 comments

Comments

@codefromthecrypt
Copy link
Member

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4 endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address.
https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

In json, both are the string formatting http://zipkin.io/zipkin-api

ipv4:
string
The text representation of a IPv4 address associated with this endpoint. Ex. 192.168.99.100
ipv6:
string
The text representation of a IPv6 address associated with this endpoint. Ex. 2001:db8::c001

@jcarres-mdsol
Copy link
Collaborator

My server will provide both ipv4 and ipv6 how do other traces do this? they provide a configuration option on which one to use?

@codefromthecrypt
Copy link
Member Author

codefromthecrypt commented Nov 2, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants