Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncReporter thread warning on shutdown in sleuth #20

Open
soumyadip007 opened this issue Jun 22, 2020 · 2 comments
Open

AsyncReporter thread warning on shutdown in sleuth #20

soumyadip007 opened this issue Jun 22, 2020 · 2 comments

Comments

@soumyadip007
Copy link

Describe the Bug

A clear and concise description of what the bug is. If you have a solution in mind, skip raising an issue and open a pull request instead.
12816 --- [on(4)-127.0.0.1] o.a.c.loader.WebappClassLoaderBase : The web application [ROOT] appears to have started a thread named [AsyncReporter{org.springframework.cloud.sleuth.zipkin2.sender.RestTemplateSender@7e9eef7a}] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread: sun.misc.Unsafe.park(Native Method)

Steps to Reproduce

Steps to reproduce the behavior:

Expected Behaviour

Zipkin is not working while kafka is running

@codefromthecrypt codefromthecrypt transferred this issue from openzipkin/zipkin Jun 23, 2020
@codefromthecrypt
Copy link
Member

Thanks for the report. please update to latest sleuth just to get code aligned with the discussion.

Meanwhile...Spring should close threads via AsyncReporter being closeable and defined as a bean AFAIK.. unless the type returned must also be closeable (vs spring looking at subtypes) Am I correct @spencergibb?

https://github.com/spring-cloud/spring-cloud-sleuth/blob/4ed3db9a2774c5418a72e480ea6f3e76a35956d4/spring-cloud-sleuth-zipkin/src/main/java/org/springframework/cloud/sleuth/zipkin2/ZipkinAutoConfiguration.java#L122

@codefromthecrypt codefromthecrypt changed the title Zipkin Kafka Issue AsyncReporter thread warning on shutdown in sleuth Jun 23, 2020
@codefromthecrypt
Copy link
Member

@soumyadip007 PS you originally titled this about Kafka. I renamed the issue about the log you pasted which has nothing to do with Kafka. In general, let's start discussions in chat https://gitter.im/spring-cloud/spring-cloud-sleuth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants