Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit support for "no-project" selected #18

Open
jldec opened this issue Apr 7, 2024 — with Linear · 2 comments
Open

Explicit support for "no-project" selected #18

jldec opened this issue Apr 7, 2024 — with Linear · 2 comments

Comments

Copy link

jldec commented Apr 7, 2024

Context

loadProject() should always return a project api, with any errors in project.errors. Since this is hard to guarantee, errors thrown by loadProject() are already partly handled in sherlock. but there are still several code paths which assume that state().project is not undefined.
e.g. here and here and bug here

Proposal

It would be nice for users to be able to select "no project" e.g. if they are working on a non-i18n package in a monorepo, and don't want to pay for sherlock resource consumption.

The option would also be helpful to disable the default project message loading for repos with one really big project (1000's of messages) which (currently) slows down vs code and probably results in users uninstalling sherlock.

Copy link
Contributor

You are right 👍 With the introduction of the project tab, there is the case of "No project could can be found" and therefore we should also handle this explicitly in the extension.

Copy link
Contributor

with SHERL-27 getting shipped, this is going to improve, but there are still some code path which can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants