-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce settings component in Sherlock 🕵️‍♂️ #2392
introduce settings component in Sherlock 🕵️‍♂️ #2392
Conversation
🦋 Changeset detectedLatest commit: e58678b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@NilsJacobsen I removed your assignment until we get the component working in the vs code webview environment inside of a framework we run there, and in this framework we then import the component. rn, I tried to use the component as is in HTML which is a bit cumbersome (but was my preferred way up until now) |
@opral/inlang-paraglide-js @opral/inlang-fink any ideas why CI is failing? something according to editor & paraglidejs ? edit: false alarm. flaky github env. |
Thanks for creating it. Gonna have a look. |
it still has a problem with settings object passing — would be cool if you can fix this!:) |
…mponent-into-sherlock
…mponent-into-sherlock
@NilsJacobsen I assign you until this is fixed from your side (I saw you have another branch open). Please assign back if you are ready and this works. related #2400 |
…mponent-into-sherlock
…mponent-into-sherlock
No you should be able to use the component as in the html example: https://github.com/opral/monorepo/blob/main/inlang/source-code/settings-component/src/stories/inlang-settings.stories.ts |
@NilsJacobsen I updated to lit-html & the new API – can you investigate why this new API isn't working? "No Inlang project found" even tho I pass one in. Thanks!:) |
@felixhaeberle the new api is not merged yet, it is blocked by a lix issue. But thanks for adding lit-html. Gonna have a look when it's ready. |
@NilsJacobsen can you link the issue instead of saying "a lix issue"? I also looked in your draft PR and can't find a link. offtopic: is the ease of linking gone now with app switching between github&linear ? |
I guess the problem is that this PR is not linked in linear. |
…mponent-into-sherlock
cc @NilsJacobsen please check your console in the extension host to see the error of the settings component. option + cmd + i
…nt-into-sherlock
…ings-component-into-sherlock
…ings-component-into-sherlock
…ings-component-into-sherlock
…ings-component-into-sherlock
…ings-component-into-sherlock
…ings-component-into-sherlock
…ings-component-into-sherlock
…ings-component-into-sherlock
…mponent-into-sherlock
…ings-component-into-sherlock
…om:inlang/monorepo into introduce-settings-component-into-sherlock
…mponent-into-sherlock
…om:opral/monorepo into introduce-settings-component-into-sherlock
@NilsJacobsen this is your playground for the settings component in sherlock
TODO's:
-> we are now ging with serializable props as decided in https://linear.app/opral/issue/INLMC-26/do-the-ui-component-props-need-to-be-serializable