Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce settings component in Sherlock 🕵️‍♂️ #2392

Merged
merged 60 commits into from
Apr 11, 2024

Conversation

felixhaeberle
Copy link
Contributor

@felixhaeberle felixhaeberle commented Mar 17, 2024

@NilsJacobsen this is your playground for the settings component in sherlock

TODO's:

  • bug: can't pass an object easily in HTML, we need some sort of framework to run the lit component in. does lit itself provide a runtime?

-> we are now ging with serializable props as decided in https://linear.app/opral/issue/INLMC-26/do-the-ui-component-props-need-to-be-serializable

  • move out of the sidebar into big window screen
  • introduce settings icon to open settings window
  • add styling to component

Copy link

changeset-bot bot commented Mar 17, 2024

🦋 Changeset detected

Latest commit: e58678b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
vs-code-extension Minor
@inlang/message-lint-rule-identical-pattern Patch
@inlang/plugin-next-intl Patch
@inlang/plugin-i18next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhaeberle felixhaeberle changed the title introduce settings component in sherlock introduce settings component in sherlock 🕵️‍♂️ Mar 17, 2024
@felixhaeberle
Copy link
Contributor Author

@NilsJacobsen I removed your assignment until we get the component working in the vs code webview environment inside of a framework we run there, and in this framework we then import the component.

rn, I tried to use the component as is in HTML which is a bit cumbersome (but was my preferred way up until now)

@felixhaeberle
Copy link
Contributor Author

felixhaeberle commented Mar 18, 2024

@opral/inlang-paraglide-js @opral/inlang-fink any ideas why CI is failing? something according to editor & paraglidejs ?

edit: false alarm. flaky github env.

@NilsJacobsen
Copy link
Collaborator

Thanks for creating it. Gonna have a look.

@felixhaeberle
Copy link
Contributor Author

it still has a problem with settings object passing — would be cool if you can fix this!:)

@felixhaeberle
Copy link
Contributor Author

felixhaeberle commented Mar 19, 2024

@NilsJacobsen I assign you until this is fixed from your side (I saw you have another branch open). Please assign back if you are ready and this works.

related #2400

@NilsJacobsen
Copy link
Collaborator

No you should be able to use the component as in the html example: https://github.com/opral/monorepo/blob/main/inlang/source-code/settings-component/src/stories/inlang-settings.stories.ts

@felixhaeberle
Copy link
Contributor Author

@NilsJacobsen I updated to lit-html & the new API – can you investigate why this new API isn't working? "No Inlang project found" even tho I pass one in. Thanks!:)

@NilsJacobsen
Copy link
Collaborator

@felixhaeberle the new api is not merged yet, it is blocked by a lix issue. But thanks for adding lit-html. Gonna have a look when it's ready.

@felixhaeberle
Copy link
Contributor Author

@NilsJacobsen can you link the issue instead of saying "a lix issue"? I also looked in your draft PR and can't find a link.

offtopic: is the ease of linking gone now with app switching between github&linear ?

@NilsJacobsen
Copy link
Collaborator

I guess the problem is that this PR is not linked in linear.
Lix issue: https://linear.app/opral/issue/LIX-36/build-error-message-skd-uses-node-specific-import

NilsJacobsen and others added 4 commits March 22, 2024 10:01
cc @NilsJacobsen please check your console in the extension host to see the error of the settings component. option + cmd + i
@samuelstroschein samuelstroschein temporarily deployed to introduce-settings-component-into-sherlock - inlang-website PR #2392 April 9, 2024 12:44 — with Render Destroyed
@samuelstroschein samuelstroschein temporarily deployed to introduce-settings-component-into-sherlock - fink-editor PR #2392 April 11, 2024 12:00 — with Render Destroyed
@felixhaeberle felixhaeberle merged commit a0f306e into main Apr 11, 2024
5 checks passed
@felixhaeberle felixhaeberle deleted the introduce-settings-component-into-sherlock branch April 11, 2024 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants