Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document page-data sideeffect quirk #2463

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

LorisSigrist
Copy link
Collaborator

There currently is an issue with the SvelteKit Adapter where side-effects of page data are triggered on language changes, even if the data isn't language dependent.

This is unfixable without breaking API changes, so for now we just document it.

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 5083daa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@inlang/paraglide-js-adapter-unplugin Patch
@inlang/paraglide-js Patch
@inlang/paraglide-js-adapter-rollup Patch
@inlang/paraglide-js-adapter-vite Patch
@inlang/paraglide-js-adapter-webpack Patch
@inlang/paraglide-js-adapter-sveltekit-example Patch
@inlang/paraglide-js-adapter-next-example-app Patch
@inlang/paraglide-js-adapter-next-example-pages Patch
@inlang/paraglide-js-adapter-next-example-turbo Patch
@inlang/paraglide-js-adapter-astro Patch
@inlang/paraglide-js-adapter-sveltekit Patch
@inlang/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LorisSigrist LorisSigrist merged commit 2b265b2 into main Mar 25, 2024
3 of 4 checks passed
@LorisSigrist LorisSigrist deleted the parjs-45--not-being-cleared branch March 25, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant