Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl pr feedback #2616

Merged
merged 3 commits into from
Apr 18, 2024
Merged

impl pr feedback #2616

merged 3 commits into from
Apr 18, 2024

Conversation

janfjohannes
Copy link
Contributor

No description provided.

@janfjohannes
impl pr feedback
7779bad 
Summary:

Test Plan:
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 99646cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@janfjohannes janfjohannes marked this pull request as ready for review April 18, 2024 23:47
@janfjohannes janfjohannes merged commit a56f407 into pr2575 Apr 18, 2024
2 checks passed
@janfjohannes janfjohannes deleted the testjan branch April 18, 2024 23:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janfjohannes