Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ninja recommend and add from subdir #3017

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

NiklasBuchfink
Copy link
Member

  • always check and add Ninja workflow in the root of the repo using findRepoRoot to create the relativePath (helper function)
  • update paraglide init to not prompt the user if Ninja is not recommend
  • add test case for shouldRecommend and add
  • refactor tests to use createNodeishMemoryFs

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: c6e26f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@inlang/recommend-ninja Patch
@inlang/paraglide-js Patch
vs-code-extension Patch
@inlang/paraglide-next Patch
@inlang/paraglide-sveltekit Patch
@inlang/paraglide-unplugin Patch
@inlang/paraglide-js-e2e Patch
@inlang/paraglide-sveltekit-example Patch
@inlang/paraglide-next-example-app Patch
@inlang/paraglide-next-example-pages Patch
@inlang/paraglide-next-example-turbo Patch
@inlang/paraglide-next-e2e Patch
@inlang/paraglide-rollup Patch
@inlang/paraglide-vite Patch
@inlang/paraglide-webpack Patch
@inlang/paraglide-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@NiklasBuchfink
Copy link
Member Author

@felixhaeberle recommend-sherlock has the same issue.

If paraglide init is executed in inland/source-code/editor, the .vs-code directory is added to the same directory instead of the root of the repo.

You can check how I solved it for Ninja and reuse the helper function I used to calculate the relative path. I also recommend refactoring the tests.

@NiklasBuchfink
Copy link
Member Author

@LorisSigrist There is a timeout in the paraglide e2e test. Probably because of this:

The prompt does not appear anymore, if the action is detected and it probably detects the one of our monorepo as there sits the repo root

@NiklasBuchfink NiklasBuchfink merged commit eb76398 into main Jul 12, 2024
3 checks passed
@NiklasBuchfink NiklasBuchfink deleted the fix-recommend-from-subdir branch July 12, 2024 08:29
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants