-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins/i18next): Use path to decide default namespace #3025
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@MrTwixxy can you sign the CLA?
thank you for the PR:) |
I have read the CLA Document and I hereby sign the CLA |
@MrTwixxy I've approved the pipeline so we can check if the changes leads to errors. |
I've fixed the tests and added a new one.
|
hey, we have to discuss this change internally as this would mean that every plugin now needs some kind of strategy on how to do |
Having the argument passed into the function doesn't necessarily mean that it has to be used right? |
@felixhaeberle i tend to agree with @MrTwixxy. just because the argument exists, doesn't mean that a plugin needs to use |
i propose to close this pr given that we will re-implement the custom API opral/inlang-sdk#125 |
Disclaimer: I haven't tested it yet, since Im unable to build myself
This fixes the default behavior of using the first namespace when there's none defined.
Useful when you have a monorepo and only want 1 sherlock project