-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode extension fails to import dynamically due to ESM #736
Comments
@shinokada Thank you for pointing this out! We currently investigating around a build time bug and will fix this soon. |
@shinokada if you are using the |
Debugging status: Local, everything works fine. In production the following error appear: From a Twitter link, I got an interesting info:
|
More information on this topic. It seems that there is a module called |
@samuelstroschein Created an issue at vscode to investigate further. Frankly, I have no clue what's going on in the VS code internals. 🥲 |
When commenting out the telemetry part, this is what happens: The line on main.cjs 8585 is: m = await import(a),
h = await Ns({ module: m, env: d }), This seems to be the reason: Edit: Fake News: dynamic import is supported in commonjs, I was tricked by an old article. I have no clue why this doesn't work then. |
@felixhaeberle This is bad. It seems like vscode (in production) is not supporting providing an import callback. Maybe for safety reasons, maybe because it's a bug. Have you skimmed through the VSCode repo if other ppl filed similar issues? Edit: The bug is on stack overflow with no answers https://stackoverflow.com/questions/75002605/vscode-extension-a-dynamic-import-callback-was-not-specified Edit 2: Found it microsoft/vscode#130367 |
@samuelstroschein This is the issue we are already subscribed to, but I though it would have been resolved through the update of electron in the latest release? They haven't closed it yet so maybe we have to wait more. |
just to have a complete history here: also linking our too early closed issue of dynamic imports. |
@felixhaeberle The issue we subscribed to was the update of Electron to a node version that supports Indeed, this is the old issue #452. Thus let's close this one here as duplicate. |
Problem
After installing the VSCode extension, I tried for Inline annotations and update translations, but not working.
Expected behavior
Should work as stated in the doc.
Steps to reproduce
CMD .
.Additional information (screenshots?)
The text was updated successfully, but these errors were encountered: