Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI chart to create a more supportable approach to overriding images #35

Open
mgianatagh opened this issue Oct 23, 2024 · 0 comments

Comments

@mgianatagh
Copy link
Member

When the command "ocne cluster start --provider none --kubeconfig $KUBECONFIG --auto-start-ui false" is used to add the UI and once-catalog to an existing cluster, the registry to use for

The registry to pull container images from can be overridden by the "registry" value in ~/.ocne/defaults.yaml. When the command "ocne cluster start --provider none --kubeconfig $KUBECONFIG --auto-start-ui false" is used, the deployments for ocne-catalog and ui need to have helm overrides applied to use the registry value. The implementation of this feature was complicated by needing to override the image: tag in an init-container. The logic needed to reapply the entire init container.

This task is to determine how to simplify the helm chart so the CLI logic can just override the image tag, without knowing the complete definition of the init-container.

Notes:

  • This task will require changes to the CLI and catalog.
  • The UI helm chart could be changed to have the init-container in the deployment template (instead of a helm value) and the value for the image could be controlled by a single value in the values.yaml. The CLI logic could then be simplified to just override the image value.
  • The change needs to be compatible with the existing CLI. It is possible for a user environment to have a CLI that expects to override the complete init-container definition, and have an app-catalog that has an updated helm chart for the UI that does not require the init container override.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant