-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated release versions to the Oct 2024 CPU. JDK 17.0.13 has a new license so it has to be download before building. #2880
Conversation
…ilable under no fee-term-and-conditions so it now requires users to download the binary first, as was the case before for JDK 8 and JDK 11. Signed-off-by: Aurelio Garcia-Ribeyro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments but nothing that blocks approval.
and fixed intendention
Fixed indentation
fixed indentation of 3 commands
Signed-off-by: Aurelio Garcia-Ribeyro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last cleanup task is to ensure that there are no whitespace characters left at the end of any line and that blank lines have no whitespace at all. There are a couple of settings in VSCode (and other editors/IDEs) to do this automatically on save.
…ents Signed-off-by: Aurelio Garcia-Ribeyro <[email protected]>
Signed-off-by: Aurelio Garcia-Ribeyro <[email protected]>
JDK 17 is no longer available under no fee-term-and-conditions so it now requires users to download the binary first, as was the case before for JDK 8 and JDK 11.
Update the checksums for 11 and 8, and the download URL for OpenJDK 23.0.1