Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the --verbose flag #1533

Open
Wwwsylvia opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1545
Open

Deprecate the --verbose flag #1533

Wwwsylvia opened this issue Nov 21, 2024 · 0 comments · May be fixed by #1545
Labels
enhancement New feature or request logging
Milestone
v1.3.0-beta.1

Comments

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Nov 21, 2024 •
edited
Loading

As per the ORAS diagnose experience proposal, we should mark the --verbose flag as deprecated for oras pull, oras push, oras attach, and oras discover commands.

  • For oras pull, oras push, oras attach commands, we should output the detailed status output by default. As a result, the output with and without --verbose will be identical.
  • For oras discover, we do not change the default output.

oras/docs/proposals/diagnose-experience.md

Lines 72 to 74 in 5280c67

- Deprecate the `--verbose` flag and keep `--debug` flag to avoid ambiguity. It is reasonable to continue using `--debug` to enable the output of `DEBUG` level logs as it is in ORAS. Meanwhile, this change will make the diagnose experience much more straightforward and less breaking since only ORAS `pull/push/attach/discover` commands have verbose output.
- Make the verbose output of commands `pull`, `push`, `attach` as the default (status) output. See examples at the bottom.
- Make the verbose output of command `discover` as a formatted output, controlled by `--format tree-full`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request logging
Projects
None yet
Milestone
v1.3.0-beta.1
Development

Successfully merging a pull request may close this issue.

refactor: deprecate --verbose and print all status output by default Wwwsylvia/oras
3 participants
@Wwwsylvia @shizhMSFT @FeynmanZhou