Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of deprecated site APIs #206

Open
5 tasks
arthurp opened this issue Aug 6, 2017 · 2 comments
Open
5 tasks

Remove all uses of deprecated site APIs #206

arthurp opened this issue Aug 6, 2017 · 2 comments

Comments

@arthurp
Copy link
Member

arthurp commented Aug 6, 2017

Orc has collected a number of external site APIs. We should clean that up. The APIs are currently marked as @depricated so it should be easy to find their uses. This issue tracks the clean up for the extremely old Java API.

The APIs are:

  • orc.values.sites.compatibility.Args
  • orc.values.sites.compatibility.DotSite
  • orc.values.sites.compatibility.PartialSite
  • orc.values.sites.compatibility.SiteAdapter
  • orc.values.sites.compatibility.Types

To remove all uses of these we will likely have to remove all the legacy Java sites. This would be a good time to rewrite them using the invoker API.

@arthurp
Copy link
Member Author

arthurp commented Aug 6, 2017

Note: The new Invoker and Accessor APIs should actually be easier to use from Java than the Site API, since all the uses of Scala collections and specialized types have been removed. The only types in the API are AnyRef and Array[AnyRef]. Which are also easy to write in Java as Object and Object[].

@arthurp arthurp changed the title Remove all uses of Java site APIs Remove all uses of deprecated site APIs Sep 19, 2018
@arthurp
Copy link
Member Author

arthurp commented Sep 19, 2018

This now includes the Scala compatibility APIs in orc.values.sites.compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant