Copyright text is not recognized in SMF

[SinanKarasu]

As the title says.

[orchetect]

Copyright is an existing text SMF event type in MIDIKit. I checked the unit tests and it's functioning correctly.

What is the contents of unrecognizedMeta? What is the metaType and data? My guess is that it may not be an actual copyright text event that you're reading.

Copyright text is encoded as 0xFF 0x02 LEN <chars>

Meta type should be 0x02 for copyright.

[SinanKarasu]

		rv.Second = MIDINote(event.note.number, style: .yamaha).name.stringValue()
		rv.Third = MIDINoteNumber.note(event.note.number).sharp

Note the first line gives me "C", the second line gives me "C4"

[SinanKarasu]

I'm going to adopt yours, and fix it later.

[orchetect]

MIDINote(event.note.number).name.stringValue() // "C"

This is returning base note name without the octave, so C is correct. I suppose the nomenclature could change and name could be called something less ambiguous like 'root' or 'degree'. MIDINote isn't really supposed to be a bastion of music theory, just a type for displaying MIDI note names according to typical DAW conventions.

MIDINote(event.note.number).stringValue() // "C4"

This what you want to return the full 'midi note name' string for display.

You can simplify this further, as event.note is already of type MIDINote:

event.note.stringValue() // "C4"

And if you haven't found it yet, you can get pretty-Unicode accidentals this way:

event.note.stringValue(unicodeAccidental: true)

[orchetect]

If you get any crashes or bugs that need addressing please open a new Issue on GitHub for each one so I can track them and make them actionable.

Let's try to keep issues/discussion threads to one question or specific subject each so that they are easier to track and may better help others, instead of a single long thread containing multiple different concerns.

[orchetect]

MIDIFile and all its subtypes now gain Hashable conformance. As well, the MIDI file parsing crash is fixed. Will push a new release soon with those changes.

That said, there may be further issues with that MIDI file which caused it to attempt to read more data than it should have, but now that the crash is resolved the specific error should surface.